Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated prop isDisabled to isFullWidth in Container #154

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

ajaymathur
Copy link
Contributor

🙂

@ajaymathur ajaymathur requested a review from jossmac July 14, 2018 11:56
@jossmac
Copy link
Member

jossmac commented Jul 15, 2018

@ajaymathur I was thinking about it like this:

The container contains things, when it's disabled the containment is released.

I'm not sure that's more clear, but thought i'd add some context.

@JedWatson
Copy link
Member

@jossmac I see what you're getting at, maybe if we say that it constrains things that might be clearer?

Mainly because "container" is really broadly used for a whole lot of reasons, not just containing within a size.

I'm happy to merge this for now, because I was confused as well 🙂

@JedWatson JedWatson merged commit 288c6d3 into master Jul 21, 2018
@JedWatson JedWatson deleted the amathur/nit-pick branch July 21, 2018 11:16
@JedWatson
Copy link
Member

thanks @ajaymathur! first PR landed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants