Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty routing key throws some error #1

Open
fizerkhan opened this issue Sep 28, 2016 · 0 comments
Open

Empty routing key throws some error #1

fizerkhan opened this issue Sep 28, 2016 · 0 comments

Comments

@fizerkhan
Copy link

fizerkhan commented Sep 28, 2016

When you have empty routing key, trailing / causes 'Action Not found' error. There are two things need to be solved here.

  1. Can you please check for empty routing key(not only for null check) and add it in URL once if it is there. If no routing key, there should not be trailing /.
  2. VictorOps returns errors in HTML. It is bit weird. It breaks the library at data = JSON.parse(response);, and It stops my server. However this is a bug from VictorOps. Can you please handle it in the library.

PS: You can check everything using following command

curl -vv --data-binary '{"message_type":"critical", "timestamp":"'$(date +%s)'", "entity_id":"disk space"}' https://alert.victorops.com/integrations/generic/20131114/alert/[YOUR_API_KEY_HERE]/[ROUTING_KEY_HERE]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant