Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included RML Strategy, fixed some mistakes, and updated sources to respect RML-IO #49

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chrdebru
Copy link
Collaborator

@anaigmo: I have removed "join" from the comment in the ontology to make rml:Strategy and rml:strategy implicitly specific to RML-CC.

@chrdebru
Copy link
Collaborator Author

@frmichel Can you check?

@frmichel
Copy link
Collaborator

frmichel commented Jul 18, 2024

Hi @chrdebru, sorry I've been away from the last discussions. I'm just confused about commit 29216b2, I though the plan was to move rml:Strategy to core, but it is reintegrated into CC here. Why is that?
How about propery rml:strategy?

@dachafra
Copy link
Member

@frmichel the explanation is here kg-construct/rml-core#51 (last comment from Ben)

@frmichel
Copy link
Collaborator

Ok got it, thx @dachafra, sorry for missing that.

@dachafra
Copy link
Member

no worries! :-)

@frmichel
Copy link
Collaborator

frmichel commented Jul 18, 2024

Just one tiny remark, the rendered.html mentions 10 January 2024 as the spec date. This is on purpose or should be updated?
Apart from that I'm good, you can merge the PR whenever you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants