Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20 Update #60

Closed
khanshoaib3 opened this issue Jun 25, 2023 · 4 comments
Closed

1.20 Update #60

khanshoaib3 opened this issue Jun 25, 2023 · 4 comments
Assignees
@khanshoaib3

Comments

@khanshoaib3
Copy link
Collaborator

Update the mod to support minecraft 1.20.x
@khanshoaib3 khanshoaib3 self-assigned this Jun 25, 2023
@khanshoaib3
Copy link
Collaborator Author

khanshoaib3 commented Jun 28, 2023 •
edited
Loading

Affected and working features-

  • Fluid Detector
  • Read Crosshair - Regular signs and hanging signs
  • Inventory Controls - Deselect/Unfocus Text fields. Thanks to @boholder it works now!
  • Time of Day
  • POI Blocks Locking - absolute positions for blocks like levers, comparator, buttons, etc. are not taken into account because the new BlockPos() now takes Vec3i instead of Vec3d. So now the locking feature locks on to the center of every block Works! Thanks to @boholder
  • Recipe section buttons
  • Book screen
  • Book edit screen

khanshoaib3 added a commit that referenced this issue Jun 28, 2023
@khanshoaib3
The content of signs' back are also now read.
4056fe8 
Signed-off-by: Mohammad Shoaib Khan <[email protected]>
#60
khanshoaib3 added a commit that referenced this issue Jun 28, 2023
@khanshoaib3
The content of signs' back are also now read. #60
2a866bd 
Signed-off-by: Mohammad Shoaib Khan <[email protected]>
khanshoaib3 added a commit that referenced this issue Jun 28, 2023
@khanshoaib3
Fixed a bug that crashes mc when opening a book edit screen #60
52fcac9 
Signed-off-by: Mohammad Shoaib Khan <[email protected]>
@boholder
Copy link
Member

boholder commented Jun 29, 2023 •
edited
Loading

I'm not sure which part of code is corresponding to Inventory Controls - Deselect/Unfocus Text fields inside InventoryControls.class...... Did you mean these code:
https://github.com/khanshoaib3/minecraft-access/blob/f615c30e3e6d80f200277d0489e8b2dcdd872b68/common/src/main/java/com/github/khanshoaib3/minecraft_access/features/inventory_controls/InventoryControls.java#L177-L214

@khanshoaib3
Copy link
Collaborator Author

Yup, these are the ones and I should've replied earlier, I don't know how I missed your message.

@boholder
Copy link
Member

boholder commented Jul 1, 2023

Yup, these are the ones and I should've replied earlier, I don't know how I missed your message.

Maybe that's because I didn't quote your reply, I don't know.

@boholder boholder mentioned this issue Jul 4, 2023
Closed
boholder referenced this issue in boholder/minecraft-access Jul 14, 2023
@boholder
Fix book edit screen tab switching buttons feature, close #60
93b8cf3
@boholder boholder mentioned this issue Jul 15, 2023
Merged
@boholder boholder mentioned this issue Aug 18, 2023
Open
@boholder boholder mentioned this issue Jan 14, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khanshoaib3 khanshoaib3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

1.20.x minecraft-access/minecraft-access
2 participants
@boholder @khanshoaib3