Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainly refactor on POI, fix #247 #248 #249

Merged
merged 14 commits into from
Jan 21, 2024
Merged

Mainly refactor on POI, fix #247 #248 #249

merged 14 commits into from
Jan 21, 2024

Conversation

boholder
Copy link
Member

Pull Request Checklist

- [ ] A new fragment is added in ./doc/news that describes what is new (refer to issue #174).

  • The unit test suite passes at the latest commit of this PR branch.

Describe what you have changed in this PR

Mainly refactor on POI, fix #247 #248.
Will append two bug fixes to version 1.5.1.

@boholder
Simplify redstone wire connecting direction checking
da168f6 
and remove unused util methods
@boholder
Fix the bug that log4j logs mod's INFO log twice in console and log f…
41c2f08 
…iles

close minecraft-access#247
@boholder
Simplify entity locking logic
958d3a8
@boholder
Rename "marking" variable to "onMarking"
e4f0dfb
@boholder
Let POI Marking speak marking target using NarrationUtils
10d75fa
@boholder
Add a helper method for narrateBlock to only get toSpeak content
dd6ee7e
@boholder
Move LockingHandler update triggering into POIMarking
352f59d
@boholder
Fix the bug that locking on Entity will immediately unlock
ce929f6 
resolve minecraft-access#248
@boholder
Let POIBlocks, POIEntities provides locking candidates to LockingHandler
b52243b
@boholder
Shrink visible scope of class fields to private in POIBlocks, POIEnti…
d879994 
…ties, LockingHandler
@boholder
Simplify marking flag passing from POIMarking to other POI classes
f73ff3c
@boholder
Update manual about POI Entity will stop when any screen is opening
1b8bfb4
@boholder
Simplify pre-checking before scanning in POIEntities
c67e437
@boholder
Update changelog about fixing bug minecraft-access#247 and minecraft-…
48bdf89 
…access#248
@boholder boholder added the 1.20 Minecraft 1.20.* version label Jan 21, 2024
@khanshoaib3 khanshoaib3 merged commit 3a71232 into minecraft-access:1.20 Jan 21, 2024
1 check passed
@boholder boholder deleted the 1.20-refactor branch January 21, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanshoaib3 khanshoaib3 khanshoaib3 approved these changes

Assignees
No one assigned
Labels
1.20 Minecraft 1.20.* version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log4j logs mod's INFO log twice in console and log files
2 participants
@boholder @khanshoaib3