Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing annotation resolver dependencies that makes test failed #280

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

boholder
Copy link
Member

Describe what you have changed in this PR

Sorry for hurrying PR without checking CI result.

@boholder boholder added the 1.20 Minecraft 1.20.* version label Apr 22, 2024
@khanshoaib3
Copy link
Collaborator

@boholder I'm at fault here too. I noticed the checks failing but thought that was due to the mod not being updated to the latest version. I forgot this is unlike stardew and things don't break that way :(

@khanshoaib3
Copy link
Collaborator

@boholder BTW what are your thoughts on keeping the main branch (1.20 atm) linear? Like the dev branch on stardew access. Currently merging directly with GH results in an extra merge commit because it doesn't do fast-forward. I added a workflow on sv access repo that merges the branch with fast-forward. We could use that if we want a linear history.

@khanshoaib3 khanshoaib3 merged commit 86964c5 into 1.20 Apr 22, 2024
2 checks passed
@boholder
Copy link
Member Author

@boholder BTW what are your thoughts on keeping the main branch (1.20 atm) linear? Like the dev branch on stardew access. Currently merging directly with GH results in an extra merge commit because it doesn't do fast-forward. I added a workflow on sv access repo that merges the branch with fast-forward. We could use that if we want a linear history.

I'll check the sv repo, I sort of get what you want to say but let me confirm that.

@boholder boholder deleted the fix-lombok-dep branch April 28, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Minecraft 1.20.* version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants