Remove architectury-api denpendence
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanshoaib3
approved these changes
May 18, 2024
|
/fast-forward |
|
[Fast Forward CI] PR cannot be merged in. Check the Actions tab for details. |
1 similar comment
|
[Fast Forward CI] PR cannot be merged in. Check the Actions tab for details. |
|
/fast-forward |
|
[Fast Forward CI] PR cannot be merged in. Check the Actions tab for details. |
khanshoaib3
force-pushed
the
remove-arch-api
branch
from
48445f9
to
d49ee7a
Compare
|
/fast-forward |
|
[Fast Forward CI] PR cannot be merged in. Check the Actions tab for details. |
1 similar comment
|
[Fast Forward CI] PR cannot be merged in. Check the Actions tab for details. |
khanshoaib3
force-pushed
the
remove-arch-api
branch
from
d49ee7a
to
0747031
Compare
|
/fast-forward |
|
[Fast Forward CI] remove-arch-api merged into 1.20... Copied the changelogs from pull request body to doc/CHANGELOG.md... Pushed the changes to origin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Others
architectury-apidenpendenceNot so hard
I managed to achieve this, https://www.perplexity.ai really helped me with forge modding knowledge (I double checked its response with searching).
I'd like to remove fabric-api too, but I can't determine the code files about "Client Tick Event Handler Registering" I need to copy from fabric-api.