Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the narrator menu if the F4 key is pressed while the menu is opening #83

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Close the narrator menu if the F4 key is pressed while the menu is opening #83

merged 1 commit into from
Jul 16, 2023

Conversation

boholder
Copy link
Member

No description provided.

@boholder
Copy link
Member Author

boholder commented Jul 14, 2023 •
edited
Loading

The conditions of which action should be taken, has grown complexity. It can be simplified into a finite-state machine, I'll solve it as a little fun challenge. The state machine implementation will has more code than current, so I give up on it.

@khanshoaib3
Copy link
Collaborator

Wow, I was thinking about adding this!

@khanshoaib3 khanshoaib3 merged commit be7ba15 into minecraft-access:default Jul 16, 2023
@boholder boholder changed the title Close the menu if the F4 key is pressed while the menu is opening Close the narrator menu if the F4 key is pressed while the menu is opening Jul 16, 2023
@boholder boholder deleted the let-f4-close-narrator-menu branch July 17, 2023 04:37
@boholder boholder added the 1.19 Minecraft 1.19.* version (1.19.3 in fact) label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanshoaib3 khanshoaib3 khanshoaib3 approved these changes

Assignees
No one assigned
Labels
1.19 Minecraft 1.19.* version (1.19.3 in fact)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boholder @khanshoaib3