Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --cherry-pick-options to add to all cherry-pick run #116

Merged
merged 1 commit into from
Apr 2, 2024
Merged

feat: add --cherry-pick-options to add to all cherry-pick run #116

merged 1 commit into from
Apr 2, 2024

Conversation

earl-warren
Copy link
Contributor

Fixes: #111

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
90.84% (-0.75% 🔻)
 446/491
🟢 Branches
85.85% (-0.42% 🔻)
 176/205
🟢 Functions 88.33% 106/120
🟢 Lines
90.78% (-0.77% 🔻)
 433/477
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡 git/git-cli.ts
64.44% (-6.29% 🔻)
33.33% (-2.38% 🔻)
 80%
64.44% (-6.29% 🔻)

Test suite run success

175 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 1437240

lampajr
lampajr requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @earl-warren, overall the PR looks great!!

There is just one required change as the options.concat method "returns a new array without modifying any existing arrays."

src/service/git/git-cli.ts Outdated Show resolved Hide resolved
@earl-warren earl-warren force-pushed the wip-cherry-pick-options branch 3 times, most recently from 4c18a4a to f89b552 Compare April 2, 2024 08:23
@lampajr
Copy link
Member

lampajr commented Apr 2, 2024

Thanks @earl-warren ❤️

@lampajr lampajr merged commit fe6be83 into kiegroup:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampajr lampajr lampajr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to transparently pass options to cherry-pick
2 participants
@earl-warren @lampajr