Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental update adds node at the end in AST instead of on its position in the resource #1

Closed
soerendomroes opened this issue Feb 20, 2020 · 1 comment

Comments

@soerendomroes
Copy link
Member

When using a layout algorithm such as rectPacking that uses the node order in the file as order in which the nodes should be displayed the following may happen:

One has a graph such as this one:

algorithm: rectPacking
aspectRatio: 3

node n1
// node n4
node n2
node n3

This produces the following drawing:
first
Uncommenting the line produces the following drawing:
second
After reopening the file the following drawing is created:
third

This might be a problem in the incremental update.
I propose that incremental update should honor the order that is defined in the file since the current solution produces different drawings without changing the model.

@soerendomroes
Copy link
Member Author

This does only occur if the node is inserted without considering the lexical order of the nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant