Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom PID controller from DXL envs #63

Open
csherstan opened this issue Apr 9, 2020 · 0 comments
Open

Remove custom PID controller from DXL envs #63

csherstan opened this issue Apr 9, 2020 · 0 comments

Comments

@csherstan
Copy link
Collaborator

Both DxlReacher1DEnv and DxlTracker1DEnv use a custom PID controller to return the motor to the starting position. This is unnecessary - it is straightforward to switch to position control.

However, to implement this change would require reworking the DXLCommunicator and providing a mechanism for specifying different control modes as the communicator assumes torque control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant