Mesh.external vestigial?

[gdmcbain]

Has the Mesh.external attribute become vestigial?

scikit-fem/skfem/mesh/mesh.py

Line 67 in 1345d38

external: Any = None

The docstring says:

scikit-fem/skfem/mesh/mesh.py

Lines 51 to 53 in 1345d38

	external
	If Mesh is loaded from external format (object), the original
	representation is kept here.

but I don't think it is set in skfem.importers.meshio.from_meshio.

In the motivating case, I did actually have an $ElementData block in a MSH 2 file which was parsed as .cell_data['quad'][my_data] by meshio.read but that's not read by skfem.importers.meshio.from_meshio.

Of course in my application I can just skip from_file and use meshio.read and from_meshio, that's not too much trouble.

Should the .external attribute just be deleted from skfem.Mesh?

Later on, if other similar applications arise, it might be worth thinking about how to generalize from_meshio to capture the cell_data beyond the 'gmsh:physical'.