-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Mesh.save logic to a separate module #291
Comments
+1 for skfem.exporters though I think we should continue to use meshio where possible and aim to fix or extend it elsewhere. In some cases it's true that different formats aren't isomorphic but often it's meshio that is incomplete. I think we get a multiplier for doing the work there rather than here, where possible; more people using, testing, and reviewing the code, writing extensions, updates, optimizations, &c. |
A possible exception to that thinking, which would particularly justify the |
A partial lightening of the burden of dependencies incurred with meshio was achieved with the eschewal of the |
Should be moved to skfem.io after #305 is merged. |
I think it would make sense to move this logic to skfem.exporters or similar:
scikit-fem/skfem/mesh/mesh.py
Line 262 in fb542a7
Also, there isn't always 1-to-1 mapping with the solution+mesh and their representation in a specific format (such as VTK). Maybe we should make this explicit, i.e. export using a combination of a solution vector and a GlobalBasis object, and make the conversion to a representation such as VTK happen automatically if there will be no loss of information, and display a warning if the conversion required interpolation/projection.
The text was updated successfully, but these errors were encountered: