Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test unsteady examples #678

Closed
gdmcbain opened this issue Aug 2, 2021 · 2 comments · Fixed by #679
Closed

test unsteady examples #678

gdmcbain opened this issue Aug 2, 2021 · 2 comments · Fixed by #679
Assignees

Comments

@gdmcbain
Copy link
Contributor

gdmcbain commented Aug 2, 2021

@kinnala, in reviewing #674 yesterday:

Can you figure out how this could be run in the test suite? In particular, tests/test_examples.py should ideally run all examples so that they won't so easily break in the future. Maybe add some call to evolve to tests/test_examples.py?

Yes, increasingly important as more initial value problems #531 are tackled.

Currently, we have

def runTest(self):
import docs.examples.ex19 as ex # noqa
# TODO improve

which will catch some things, but I think it'll be easy enough to test evolution, as suggested.

@gdmcbain
Copy link
Contributor Author

gdmcbain commented Aug 2, 2021

I see that a few steady examples are in the same boat:

I think they're all mine too!

@gdmcbain
Copy link
Contributor Author

gdmcbain commented Aug 3, 2021

Right, exx17, 18, e.g., had test-like print-statements in the scripts; I've moved those to tests.test_examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant