Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substance] Tooltips' shadows bleed through overlapping windows #338

Closed
asvitkine opened this issue May 26, 2021 · 4 comments
Closed

[Substance] Tooltips' shadows bleed through overlapping windows #338

asvitkine opened this issue May 26, 2021 · 4 comments
Assignees
Labels
4.0 - Feldspar Release 4.0 - 2021.H1

Comments

@asvitkine
Copy link

Version of Radiance (current development is 4.0-SNAPSHOT)

Substance 3.5.1

Sub-project (Neon, Trident, Substance, Flamingo, ...)

Substance

Version of Java (current minimum is 9)

16.0.1

Version of OS

Window 10

The issue you're experiencing (expected vs actual, screenshot, stack trace etc)

If you have two windows A and B and a tooltip is shown from A while B is above it, the tooltip's border will bleed window A's contents over.

The screenshot below demonstrates (via https://github.com/triplea-game/triplea which uses Substance):
Screenshot 2021-05-25 232855

In the screenshot, there's a tooltip shown about the mouse-over Tank from the background window and the tooltip correctly displays frontmost, but its border is showing the contents of the background window.

@kirill-grouchnikov
Copy link
Owner

This is coming from the implementation in https://github.com/kirill-grouchnikov/radiance/blob/sunshine/substance/src/main/java/org/pushingpixels/substance/internal/contrib/jgoodies/looks/common/ShadowPopup.java which was taken quite a few years ago from JGoodies' Looks library.

I think the time has come to retire that whole functionality and use whatever tooltip "decoration" (drop shadow or flat) comes from the OS. That would also apply to menus and other popup windows across Radiance-powered components.

@kirill-grouchnikov kirill-grouchnikov self-assigned this May 26, 2021
@kirill-grouchnikov kirill-grouchnikov added the 4.0 - Feldspar Release 4.0 - 2021.H1 label May 26, 2021
@kirill-grouchnikov
Copy link
Owner

Fixed with 8c6e9bf

@asvitkine
Copy link
Author

Thanks for the quick fix! I guess this will just make it to the 4.0 release? Or is there a chance to backport it to 3.5.2 or similar?

@kirill-grouchnikov
Copy link
Owner

This will be in 4.0 release. I don't have resources to backport fixes to earlier releases beyond the first week after a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 - Feldspar Release 4.0 - 2021.H1
Projects
None yet
Development

No branches or pull requests

2 participants