Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Unify fire action trigger logic for command buttons #372

Closed
kirill-grouchnikov opened this issue Dec 20, 2021 · 0 comments
Closed

[Component] Unify fire action trigger logic for command buttons #372

kirill-grouchnikov opened this issue Dec 20, 2021 · 0 comments
Assignees
@kirill-grouchnikov
Labels
6.0 - Iridium Release 6.0 - 2022.H2 Breaking change Marking changes that break backwards compatibility

Comments

@kirill-grouchnikov
Copy link
Owner

Replace CommandButtonPresentationModel.isFireActionOnRollover and CommandButtonPresentationModel.isFireActionOnPress with a single actionFireTrigger enum that has three values:

  • OnRollover to fire action on rollover
  • OnPressed to fire action on press
  • OnPressReleased to fire action on press release (the default)
@kirill-grouchnikov kirill-grouchnikov added Breaking change Marking changes that break backwards compatibility 6.0 - Iridium Release 6.0 - 2022.H2 labels Dec 20, 2021
@kirill-grouchnikov kirill-grouchnikov self-assigned this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirill-grouchnikov kirill-grouchnikov

Labels
6.0 - Iridium Release 6.0 - 2022.H2 Breaking change Marking changes that break backwards compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirill-grouchnikov