You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is actually a good time to remove the plain template altogether.
That template is a more of a curiosity and would need additional app-side code to configure the size of the icon, for each icon - that is something that comes built-in with the RadianceIcon.
I don't really want to start having some sort of a feature-aware template system, where a template can specify (via command-line flags in any case, so no much of a system) which extra features it supports - such as color filtering. It's certainly possible to start with this one-off and not emit the color filtering instructions, but I don't want to go down that road.
In general, I view Radiance as a cohesive set of libraries, and bundling a plain template breaks that cohesion.
kirill-grouchnikov
changed the title
SVG Transcoder emits invalid Java code with PLAIN template (incorrectly references colorFilter)
[SVG Transcoder] Remove plain template
Mar 18, 2022
Version of Radiance (latest development is 6.0-SNAPSHOT)
5.0.0
Sub-project (Common, Animation, Theming, Component, ...)
svg-transcoder
Version of Java (current minimum is 9)
11
Version of OS
macOs 12.3
The issue you're experiencing (expected vs actual, screenshot, stack trace etc)
The generated code with the plain template is incorrect as code has references to
colorFilter
:This field reference can be found in the Radiance template :
radiance/tools/svg-transcoder/src/main/resources/org/pushingpixels/radiance/tools/svgtranscoder/api/java/SvgTranscoderTemplateRadiance.templ
Line 27 in 46319b1
It's initialized there.
radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java
Lines 228 to 233 in 46319b1
But it's not there in the plain template.
However the
colorFilter
is used regardless of the template.radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java
Line 453 in 46319b1
radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java
Line 854 in 46319b1
radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java
Line 920 in 46319b1
radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java
Line 963 in 46319b1
The text was updated successfully, but these errors were encountered: