[SVG Transcoder] Remove plain template

[bric3]

Version of Radiance (latest development is 6.0-SNAPSHOT)

5.0.0

Sub-project (Common, Animation, Theming, Component, ...)

svg-transcoder

Version of Java (current minimum is 9)

11

Version of OS

macOs 12.3

The issue you're experiencing (expected vs actual, screenshot, stack trace etc)

The generated code with the plain template is incorrect as code has references to colorFilter :

// _0_0
shape = new Ellipse2D.Double(7.0, 7.0, 10.0, 10.0);
paint = (colorFilter != null) ? colorFilter.filter(new Color(0, 0, 0, 255)) : new Color(0, 0, 0, 255);
g.setPaint(paint);
g.fill(shape);

This field reference can be found in the Radiance template :

radiance/tools/svg-transcoder/src/main/resources/org/pushingpixels/radiance/tools/svgtranscoder/api/java/SvgTranscoderTemplateRadiance.templ

Line 27 in 46319b1

private RadianceIcon.ColorFilter colorFilter = null;

It's initialized there.

radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java

Lines 228 to 233 in 46319b1

	String setColorFilter = this.hasRasters
	? "throw " + this.languageRenderer.getObjectCreation("UnsupportedOperationException") +
	"(\"Color filters on raster content not supported\")"
	: "this.colorFilter = colorFilter";
	templateString = templateString.replace(TOKEN_SET_COLOR_FILTER,
	setColorFilter + this.languageRenderer.getStatementEnd());

But it's not there in the plain template.

However the colorFilter is used regardless of the template.

radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java

Line 453 in 46319b1

"(" + languageRenderer.getNullableInvocation("colorFilter", "filter", colorParameter) + ")");

radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java

Line 854 in 46319b1

"(" + languageRenderer.getNullableInvocation("colorFilter", "filter", colorParameter) + ")");

radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java

Line 920 in 46319b1

languageRenderer.getNullableInvocation("colorFilter", "filter", colorParameter) +

radiance/tools/svg-transcoder/src/main/java/org/pushingpixels/radiance/tools/svgtranscoder/api/SvgBaseTranscoder.java

Line 963 in 46319b1

languageRenderer.getNullableInvocation("colorFilter", "filter", colorParameter) +

[kirill-grouchnikov]

This is actually a good time to remove the plain template altogether.

That template is a more of a curiosity and would need additional app-side code to configure the size of the icon, for each icon - that is something that comes built-in with the RadianceIcon.

I don't really want to start having some sort of a feature-aware template system, where a template can specify (via command-line flags in any case, so no much of a system) which extra features it supports - such as color filtering. It's certainly possible to start with this one-off and not emit the color filtering instructions, but I don't want to go down that road.

In general, I view Radiance as a cohesive set of libraries, and bundling a plain template breaks that cohesion.