You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue you're experiencing (expected vs actual, screenshot, stack trace etc)
theming/src/main/java/org/pushingpixels/radiance/theming/internal/utils/RadianceCoreUtilities.java declares a toShowExtraWidgets function, documented as
@returntrue if the specified component has extra Radiance-specific UI elements, false otherwise.
But it actually has this behaviour:
ObjectcomponentProp = jcomp.getClientProperty(RadianceSynapse.SHOW_EXTRA_WIDGETS);
if (componentProp != null) {
if (Boolean.TRUE.equals(componentProp))
returnfalse;
if (Boolean.FALSE.equals(componentProp))
returntrue;
}
That is, if the user sets SHOW_EXTRA_WIDGETS to false, it returns true, and vice versa.
@param extraWidgetsPresence If true, extra UI elements (such as menu items in system menu or lock borders) will be shown in the component. Pass null to reset to the default behavior.
The check in toShowExtraWidgets makes this docstring contradictory, so I am relatively sure that it's a bug.
Found with a debugger while trying to get a lock border on a specific text field.
The text was updated successfully, but these errors were encountered:
kirill-grouchnikov
changed the title
toShowExtraWidgets is backwards??
[Theming] Incorrect inverted logic of ComponentOrParentChainScope.setExtraWidgetsPresence
Aug 21, 2022
Version of Radiance (latest development is 6.0-SNAPSHOT)
5addb52
Sub-project (Common, Animation, Theming, Component, ...)
Theming
The issue you're experiencing (expected vs actual, screenshot, stack trace etc)
theming/src/main/java/org/pushingpixels/radiance/theming/internal/utils/RadianceCoreUtilities.java
declares atoShowExtraWidgets
function, documented asBut it actually has this behaviour:
That is, if the user sets
SHOW_EXTRA_WIDGETS
to false, it returns true, and vice versa.Compare
org/pushingpixels/radiance/theming/api/RadianceThemingCortex.java
:Documented as:
The check in
toShowExtraWidgets
makes this docstring contradictory, so I am relatively sure that it's a bug.Found with a debugger while trying to get a lock border on a specific text field.
The text was updated successfully, but these errors were encountered: