Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theming] RadianceTextUtilities.getForegroundColor should not return null for empty texts #466

Closed
kirill-grouchnikov opened this issue Mar 29, 2024 · 0 comments
Assignees
Labels
7.5 - Larimar Release 7.5 - 2024.H1

Comments

@kirill-grouchnikov
Copy link
Owner

That logic does not belong in the foreground color computation.

In its current state, the logic is broken for cases such as icon-only command buttons in disabled state, as the text check short circuits the logic, returns null, and that is then treated to draw the icon with enabled state visuals.

@kirill-grouchnikov kirill-grouchnikov added the 7.5 - Larimar Release 7.5 - 2024.H1 label Mar 29, 2024
@kirill-grouchnikov kirill-grouchnikov self-assigned this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.5 - Larimar Release 7.5 - 2024.H1
Projects
None yet
Development

No branches or pull requests

1 participant