Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library search should diacritics insensitive #2638

Open
gouri-panda opened this issue Apr 8, 2021 · 9 comments
Open

Library search should diacritics insensitive #2638

gouri-panda opened this issue Apr 8, 2021 · 9 comments
Assignees
Milestone

Comments

@gouri-panda
Copy link
Collaborator

looks like if you search something in the online library, the selected language does not apply
so i choose french in languages... but if I search "Wikipedia" I don't get (first) the result (zim books) in french

@gouri-panda gouri-panda added the bug label Apr 8, 2021
@kelson42 kelson42 added this to the 3.4 milestone Apr 8, 2021
@kelson42
Copy link
Collaborator

kelson42 commented Apr 8, 2021

@gouri-panda Thx for opening the ticket... this is quite a critical bug (regression) as it almost remove the ability to find new books to download in the user language.

@kelson42
Copy link
Collaborator

kelson42 commented Apr 8, 2021

For a dummy research "Wikipedia" which should give books in each language, we see no entry "Selected languages:" but only "Other languages" with basically all the content of zero value for the user.
Screenshot_20210408-124258.png

@gouri-panda
Copy link
Collaborator Author

Here we are searching "Wikipedia" instead of "Wikipèdia". So we don't get the expected result.

@kelson42
Copy link
Collaborator

This problem should be fixed automatically if we use OPDS in place of custom library_zim.xml handling.

@kelson42 kelson42 modified the milestones: 3.4, 3.5 Apr 13, 2021
@kelson42 kelson42 added enhancement and removed bug labels May 22, 2021
@kelson42 kelson42 changed the title Zim files doesn't show according to the language Library search shoukd diacritics insensitive May 22, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@kelson42 kelson42 changed the title Library search shoukd diacritics insensitive Library search should diacritics insensitive Jun 28, 2022
@stale stale bot removed the stale label Jun 28, 2022
@kelson42
Copy link
Collaborator

kelson42 commented Jun 28, 2022

This should be automatically fixed by using latest libkiwix and OPDS library.

@kelson42 kelson42 modified the milestones: 3.7.0, 3.6.1 Jun 28, 2022
@kelson42 kelson42 modified the milestones: 3.7.0, 3.8.0 Jul 2, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@kelson42 kelson42 removed this from the 3.8.0 milestone Dec 29, 2022
@kelson42 kelson42 added this to the 3.7.0 milestone Dec 29, 2022
@stale stale bot removed the stale label Dec 29, 2022
@kelson42
Copy link
Collaborator

kelson42 commented Dec 29, 2022

This will be fixed within the « Room » project, by just using the libkiwix12 to handle local and remote library. @gouri-panda nothing special to do it first.

@gouri-panda
Copy link
Collaborator Author

@kelson42 Sure!

@kelson42 kelson42 modified the milestones: 3.7.0, 3.8.0 May 19, 2023
@kelson42 kelson42 modified the milestones: 3.8.0, 3.9.0 Aug 27, 2023
@kelson42 kelson42 modified the milestones: 3.12.0, 3.13.0 Jul 12, 2024
@kelson42 kelson42 modified the milestones: 3.14.0, 3.13.0 Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants