Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks/Notes get lost if ZIM file is updated (in particular in custom apps) #3632

Open
kelson42 opened this issue Dec 27, 2023 · 4 comments
Assignees
Labels
bug custom apps Supporting the design & development of custom apps
Milestone

Comments

@kelson42
Copy link
Collaborator

If we update a ZIM file, the bookmarks created formerly remains linked to to old ZIM file, and stop working.
In case of custom apps, this means losing all bookmarks at each update.

Create a plan how we can improve this on the iOS/macOS side.

Depends on kiwix/libkiwix#1037 and #3109

@kelson42 kelson42 added bug custom apps Supporting the design & development of custom apps labels Dec 27, 2023
@kelson42 kelson42 added this to the 3.10.0 milestone Dec 27, 2023
@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz Actually we have the same bug with the notes. You confirm?

@kelson42 kelson42 changed the title Bookmarks get lost if ZIM file is updated (in particular in custom apps) Bookmarks/Notes get lost if ZIM file is updated (in particular in custom apps) Jan 30, 2024
@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 If we update the ZIM file, and if the metadata will change specifically article URLs, Title, and Name will change then we lose the notes. As shown below we are saving/retrieving the notes on behalf of these metadata.

val articleUrl = (activity as WebViewProvider?)?.getCurrentWebView()?.url
var noteFileName = ""
if (articleUrl == null) {
onFailureToCreateAddNoteDialog()
} else {
noteFileName = getTextAfterLastSlashWithoutExtension(articleUrl)
}
return noteFileName.ifEmpty { articleTitle } ?: ""

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz please answer me with yes or no.

@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 Yes, the same bug with notes if we update the ZIM file.

@kelson42 kelson42 modified the milestones: 3.10.0, 3.11.0 Mar 20, 2024
@kelson42 kelson42 modified the milestones: 3.11.0, 3.12.0 May 19, 2024
@kelson42 kelson42 modified the milestones: 3.12.0, 3.13.0 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug custom apps Supporting the design & development of custom apps
Projects
None yet
Development

No branches or pull requests

2 participants