Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated libkiwix methods #445

Closed
kelson42 opened this issue May 9, 2022 · 3 comments
Closed

Stop using deprecated libkiwix methods #445

kelson42 opened this issue May 9, 2022 · 3 comments

Comments

@kelson42
Copy link
Contributor

kelson42 commented May 9, 2022

libkiwix 10.x.y have deprecated many methods and function which I guess are still in used in Kiwix iOS and macOS. This has two consequences:

  • Many warning at Kiwix compilation time
  • Stop us to removed these old/deprecated primitives in future libkiwix releases.

Would be beneficial to remove the usage of these deprecated methods and use modern/new API of libkiwix.

The effort has already been made in Kiwix Tools, see kiwix/kiwix-tools#535 and this PR might help to know what to do with Kiwix For iOS and macOS.

@automactic
Copy link
Member

automactic commented May 21, 2022

Are the classes mentioned in kiwix/libkiwix#430 all that needs to be updated? If it is all, then I have already finished migrating to the new classes

@kelson42
Copy link
Contributor Author

@automactic The list is not complete IMO, just make a compilation run and see if you have deprecation warnings. If not, then this is Ok.

@automactic
Copy link
Member

There are no deprecation warnings right now. Looks like I can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants