Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP daemon does not have a proper human friendly name if not started with kiwix-serve #676

Closed
kelson42 opened this issue Feb 17, 2021 · 3 comments · Fixed by #678
Closed
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Collaborator

If started with Kiwix Desktop, URL look like:
http://192.168.0.101:8181/search?content=5149203d-1c60-a927-0095-278e34e6897a&pattern=estrutura+biologica

I suspect the problem comes from the humanfriendly() function which probably falls back.

This function should be fixed and in place of using the ZIM filename (which probably is not available here), it should build the human friendly name from the ZIM metadata (name, publisher, date, flavour).

@MananJethwani
Copy link
Contributor

@kelson42 shouldn't this be in kiwix-desktop? I suppose this is related to QWebEngine.

@kelson42
Copy link
Collaborator Author

@MananJethwani No, quite sure, the bug is here in the libkiwix.

@stale
Copy link

stale bot commented Jun 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants