Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg book titles with quotation marks fail to open when clicked from the custom UI #226

Closed
Jaifroid opened this issue Jan 10, 2022 · 3 comments

Comments

@Jaifroid
Copy link
Member

This is a specific regression in Kiwix JS Windows in SW mode. It doesn't affect Kiwix JS in SW mode, which proves the issue is with KJSW code.

When clicking on a title that contains quotation marks from the custom UI in Gutenberg ZIMs, the book cover fails to open. The same book can be opened by searching for its title in the standard Kiwix JS Windows search box.

This is no doubt due to the code that analyses external links and opens them in a new window.

@Jaifroid
Copy link
Member Author

I believe this is fixed in latest release, subject to proper testing.

@kelson42
Copy link
Contributor

Would ne good to know which zim file and which article has a problem.

@Jaifroid
Copy link
Member Author

This is definitely fixed. It was a specific issue with KJSW, not a ZIM issue per se. For the record, I was testing on gutenberg_it_all_2022-01.zim and sorting the books by alphabetical order, then choosing those with quotation marks in the title. There was a separate issue affecting both KJS and KJSW for book titles with question marks (kiwix/kiwix-js#806), which was fixed upstream, and the fix incorporated here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants