Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement pkgconfig libkiwix #1117

Closed
kelson42 opened this issue Sep 1, 2024 · 3 comments · Fixed by #1133
Closed

Improvement pkgconfig libkiwix #1117

kelson42 opened this issue Sep 1, 2024 · 3 comments · Fixed by #1133
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Sep 1, 2024

Why the naming is different? We have kiwix and libzim:

/usr/local/lib/x86_64-linux-gnu/pkgconfig/kiwix.pc
/usr/local/lib/x86_64-linux-gnu/pkgconfig/libzim.pc

It should not be libkiwix.pc?

Why we do have kiwix.pc.in in our code repo, but nothing similar at libzim level?

@kelson42 kelson42 added this to the 14.0.0 milestone Sep 1, 2024
@mgautierfr
Copy link
Member

Why we do have kiwix.pc.in in our code repo, but nothing similar at libzim level?

Probably because libzim has been update to use the meson module pkgconfig and libkiwix is still using the older method of having a template file.

Why the naming is different? We have kiwix and libzim:

Historical reason. Probably a random guy (me) put this name and we stay with it.
Be careful if you change it. Other project will need to update to search for libkiwix instead of kiwix.

@kelson42
Copy link
Collaborator Author

kelson42 commented Sep 2, 2024

So we could agree that?

  • It should be libkiwix
  • We should use Meson and remove kiwix.pc.in?

Considering we are just about releasing version 14.0.0, this would be a good time to do it IMHO

@kelson42 kelson42 changed the title Questions about pkgconfig libkiwix Improvement pkgconfig libkiwix Sep 2, 2024
@kelson42
Copy link
Collaborator Author

@veloman-yunkan I have put this issue as well in the milestone as this can only be done in a major release and the fix seems trivial to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants