-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable on a page doesn't effect the website #707
Comments
@andreapx This is a known regression (#705) of the latest CanvasBlocker update, it will be fixed in the next version. In the meantime you can switch to the latest beta version (self-hosted on https://canvasblocker.kkapsner.de/versions/?C=M;O=D), where the fix(es) are already included, just make sure to disable the "regular" CanvasBlocker when the beta version is enabled. |
@spodermenpls thanks for your kind reply! |
@andreapx That depends mostly on the speed of the manual code review done by Mozilla, since CanvasBlocker is one of its "recommended addons" and has to jump through that hoop, before it is publicly available. But as I've said, the beta version including the fix is already there, it just needs a few clicks to install it. |
Thanks for the bug report, I was about to file a similar one while investigating my own Grafana issues :) |
@spodermenpls I've installed the latest beta (1.10.1), but the problem persist, I've disabled Canvas blocker in a single website (Grafana), but I still have the problem. If I completely disable it, Grafana works. |
@andreapx The latest beta is named 1.11 (https://canvasblocker.kkapsner.de/versions/?C=M;O=D), 1.10.1 is the old and faulty release version. Over at #705, two people reported that the changes in the beta version fixed the Grafana issue, so I'd be surprised if it really doesn't work in your case. |
@spodermenpls I'm on V 1.11.20240417 but I still have the problem... :( |
Not sure if this helps, but I lost the whitelist when installing the beta. I did not recreate it, but during the setup screen I applied the convenience settings and the reCAPTCHA fix, and Grafana is working fine again for me. |
@heyarne What do you mean by "losing the whitelist", I guess the fact that the Beta version is installed from scratch, and doesn't contain/import any of the settings made by a user inside the normal release version? @andreapx Does Grafana work with the Beta version, when you use the same settings as you have with the release version, in particular with the custom reCAPTCHA setting? You can use the "save" and "load" feature at the bottom of the settings panel, to export and import the settings between "release" CB and "beta" CB very quickly. |
The current beta fixes my Grafana problem. Whew. Any idea what the hold-up is? 3+ months for a regression fix is kindof uncomfortably long. |
Description
I have a problem with Grafana (hosted in LAN): until yesterday the Grafana webpage was working without a problem, now it trows an error.
If I completely disable CanvasBlocker addon, Grafana starts to work, but it I enable CanvasBlocker and disable it in the Grafana website, the page won't load.
Expected Behaviour
A complete shut off if I disable it in a single website
Current Behaviour
CanvasBlocker still does something when disabled on a single website
Steps to Reproduce (for bugs)
Your Environment
Your Settings
The text was updated successfully, but these errors were encountered: