Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 54c625c introduced regression #715

Open
alemonmk opened this issue Jun 28, 2024 · 3 comments
Open

Commit 54c625c introduced regression #715

alemonmk opened this issue Jun 28, 2024 · 3 comments
Labels
Milestone

Comments

@alemonmk
Copy link

Description

Reflect.setPrototypeOf takes null for argument prototype. However, the altered setPrototypeOf() called getPrototypeOf() which throws on null without a null check. Which caused an Uncaught TypeError in near-membrane-shared and could be stopping Grafana's (affected my 11.0, wikipedia's 9.5 is fine) web UI from loading. Disabling the plugin will let Grafana load properly.

Expected Behaviour

Grafana UI should load properly.

Current Behaviour

Grafana stopped loading and showing error message: "Grafana has failed to load its application files"

Steps to Reproduce (for bugs)

  1. Install CanvasBlocker
  2. Visit a Grafana v11 installation

Your Environment

  • CanvasBlocker Version used: 1.10.1
  • Firefox version incl. 32- or 64-bit: 64-bit
  • Operating System and version (desktop or mobile): Windows 10 21H2
  • Installed addons: CanvasBlocker, uBlock Origin, Referer Modifier, LocalCDN, Cookie Quick Manager, DownThemAll!, Duplicate Tabs Closer, Firefox Multi-Account Containers, HyperChat and PocketTube

Your Settings

{
	"logLevel": 1,
	"urlSettings": [
		{
			"url": "challenges.cloudflare.com",
			"protectedCanvasPart": "nothing"
		}
	],
	"hiddenSettings": {
		"enableStackList": false,
		"protectedCanvasPart": false,
		"protectedAPIFeatures": false
	},
	"expandStatus": {
		"section_lists": true,
		"protectNavigator": true,
		"useAudioCache": false,
		"protectedCanvasPart": true,
		"protectAudio": false,
		"protectScreen": false
	},
	"displayHiddenSettings": true,
	"whiteList": "\n",
	"sessionWhiteList": "",
	"blackList": "",
	"blockMode": "fake",
	"protectedCanvasPart": "readout",
	"minFakeSize": 1,
	"maxFakeSize": 0,
	"rng": "nonPersistent",
	"protectedAPIFeatures": {},
	"useCanvasCache": true,
	"ignoreFrequentColors": 0,
	"minColors": 0,
	"fakeAlphaChannel": true,
	"webGLVendor": "",
	"webGLRenderer": "",
	"webGLUnmaskedVendor": "",
	"webGLUnmaskedRenderer": "",
	"persistentRndStorage": "",
	"persistentIncognitoRndStorage": "",
	"storePersistentRnd": false,
	"persistentRndClearIntervalValue": 0,
	"persistentRndClearIntervalUnit": "days",
	"lastPersistentRndClearing": 1719591123928,
	"sharePersistentRndBetweenDomains": false,
	"askOnlyOnce": "individual",
	"askDenyMode": "block",
	"showCanvasWhileAsking": true,
	"showNotifications": true,
	"highlightPageAction": "none",
	"highlightBrowserAction": "color",
	"displayBadge": false,
	"storeNotificationData": false,
	"storeImageForInspection": false,
	"ignoreList": "",
	"ignoredAPIs": {},
	"showCallingFile": false,
	"showCompleteCallingStack": false,
	"enableStackList": false,
	"stackList": "",
	"protectAudio": true,
	"audioFakeRate": "100",
	"audioNoiseLevel": "low",
	"useAudioCache": true,
	"audioUseFixedIndices": true,
	"audioFixedIndices": "6",
	"historyLengthThreshold": 2,
	"protectWindow": false,
	"allowWindowNameInFrames": false,
	"protectDOMRect": true,
	"domRectIntegerFactor": 4,
	"protectSVG": true,
	"protectTextMetrics": true,
	"blockDataURLs": true,
	"protectNavigator": false,
	"navigatorDetails": {},
	"protectScreen": true,
	"screenSize": "",
	"fakeMinimalScreenSize": true,
	"displayAdvancedSettings": true,
	"displayDescriptions": false,
	"theme": "auto",
	"showPresetsOnInstallation": true,
	"dontShowOptionsOnUpdate": false,
	"disruptSessionOnUpdate": false,
	"updatePending": false,
	"isStillDefault": false,
	"storageVersion": 1
}
@kkapsner
Copy link
Owner

kkapsner commented Jul 3, 2024

3eedc7b should solve this problem. Please check with the latest alpha: https://canvasblocker.kkapsner.de/versions/?C=M;O=D

@kkapsner kkapsner added this to the Version 1.11 milestone Jul 3, 2024
@kkapsner kkapsner added the bug label Jul 3, 2024
@alemonmk
Copy link
Author

alemonmk commented Jul 5, 2024

Hi @kkapsner, the fix works, thank you for the prompt response.

@KiARC
Copy link

KiARC commented Jul 18, 2024

Any timeframe of when this will make it to stable? Whitelisting the site in question (also a Grafana instance for me) doesn't fix it, so I'd love to know when this will be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants