Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Version up with eventemitter3 #21

Closed
jimni1222 opened this issue Jul 4, 2019 · 0 comments · Fixed by #22
Closed

Version up with eventemitter3 #21

jimni1222 opened this issue Jul 4, 2019 · 0 comments · Fixed by #22
Assignees
Labels
closed/fixed A fix for the issue was provided. issue/enhancement Issues for enhancement requests. open/approved The issue is confirmed as being a bug to be fixed or enhancement to be developed.

Comments

@jimni1222
Copy link
Contributor

jimni1222 commented Jul 4, 2019

Is your request related to a problem? Please describe.
Caver-js is using the v1.1.1 version of eventemitter3.
Update eventemitter3 to the latest version (v4.0.0).
In the release notes of eventemitter3, the distribution for performance improvement was done after version 1.1.1.

Describe the solution you'd like
Update eventemitter3 version to 4.0.0.

Describe alternatives you've considered
Update to the version close with latest version.

Additional context

web3.js also updated version of eventemitter3 before, but it did not seem to update because of vulnerability issue in particular.
Note that we will leave the link below.
web3/web3.js@48ccfcb?diff=unified
web3/web3.js#2905

@jimni1222 jimni1222 added the issue/enhancement Issues for enhancement requests. label Jul 4, 2019
@jimni1222 jimni1222 self-assigned this Jul 4, 2019
@jimni1222 jimni1222 added the open/approved The issue is confirmed as being a bug to be fixed or enhancement to be developed. label Jul 4, 2019
@jimni1222 jimni1222 added the closed/fixed A fix for the issue was provided. label Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed/fixed A fix for the issue was provided. issue/enhancement Issues for enhancement requests. open/approved The issue is confirmed as being a bug to be fixed or enhancement to be developed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant