-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The binary size of kmeshctl
seems too large
#946
Comments
https://github.com/loov/goda And many other similar tools are there |
/assign |
Hey @hzxuzhonghu I’ve used goda to generate the dependency graph, but I haven’t been able to identify any unnecessary dependencies. It’s possible that I’m not analyzing it correctly. I need your help After adding -s -w to the ldflags, the sizes of the binaries are as follows:
Do you think these sizes are sufficient? Should we consider adding DEBUG flags like all=-N -l, similar to what Kubernetes and Istio do? kubernetes
istio
|
The graph is based on kmesh-daemon? I agree with the suggestion by building with release flag |
This is generated with goda tree, ptal, |
We can construct port-forwarder from k8s.io/kubectl/pkg/cmd/portforward |
I apologize for my misunderstanding of how to use Goda. The graph was actually generated by the command |
Thank you for your advice! I really appreciate it, and I will try to write it down. |
Task description:
The binary size of
kmeshctl
as follows:In contrast, the binary size of
istioctl
is:size of
kubectl
is:size of
kmesh-daemon
:[root@kmesh-p6cb9 kmesh]# ls -lh /usr/bin/kmesh-daemon -r-xr--r-- 1 root root 120M Oct 8 02:59 /usr/bin/kmesh-daemon
Solution:
Maybe optimize go compilation options or remove unnecessary dependencies?
Who can join or take the task:
The good first issue is intended for
first-time contributors
to get started on his/her contributor journey.After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to
help wanted
items, saving the remaininggood first issue
for other new contributors.How to join or take the task:
Just reply on the issue with the message
/assign
in a separate line.Then, the issue will be assigned to you.
How to ask for help:
If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.
The text was updated successfully, but these errors were encountered: