Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option to disable scrolling #157

Open
OtisBee opened this issue Dec 24, 2018 · 15 comments · May be fixed by #205
Open

Feature Request: Option to disable scrolling #157

OtisBee opened this issue Dec 24, 2018 · 15 comments · May be fixed by #205

Comments

@OtisBee
Copy link

OtisBee commented Dec 24, 2018

First off

Big respect and many thanks for this fine app, kmikiy.
I'm totally loving it and consider it as a definite must have.
Wouldn't wanna miss it.

Versions

SpotMenu version: 1.9.0
MacOS version: 10.14.2

Okay, let's get to it

...I'm fully aware that on a crowded menu bar screen real estate is of the essence and therefore it is great to have the track infos scrolling now.

But then again, if on a 27" iMac there's no lack of screen real estate, then why not provide an option to turn said scrolling off again.

Previously I was able to give the menu bar a quick glance and then I was fully aware of what's currently playing. No truncation of track infos whatsoever regardless of the length of those track infos.

But not anymore. The one thing i liked most about SpotMenu has vanished.

Please make it come back. Perhaps by way of adding an option to toggle scrolling on/off?

That would be so great.

I hope you consider this request.

Thanks again
Otis

@kmikiy
Copy link
Owner

kmikiy commented Dec 24, 2018

Hey 👋🏻 Thanks for the feedback. I will add an option to disable scrolling. Meanwhile here's a custom build just for you with scrolling disabled.

@OtisBee
Copy link
Author

OtisBee commented Dec 25, 2018

Wow, that was quick :))
Thanks so much!!

@kmikiy
Copy link
Owner

kmikiy commented Dec 25, 2018

You might have also noticed that the text is vertically off by 1 pixel. This build fixes that.

Edit:

  • contains scrolling
  • vertical alignment fixed
  • spacing fixed

@OtisBee
Copy link
Author

OtisBee commented Dec 25, 2018

Indeed I did. :)

In fact, I thought about posting yet another feature request to maybe add a thin progressbar underneath the track infos (or maybe an option to assign a different color to the text) and when I checked whether there'd be enough space for such a progressbar that's when I noticed that the text is a tad off.

Anyways, thanks for the fixing build.

Unfortunately that build has scrolling enabled by default again tho, so I think I'll stick to that previous build for now.

@kmikiy
Copy link
Owner

kmikiy commented Dec 25, 2018

My apologies. Here's an updated build for you.

  • no scrolling
  • vertical alignment fixed
  • spacing fixed

@OtisBee
Copy link
Author

OtisBee commented Dec 25, 2018

Perfect!!
Once again: great support
Thanks

@kbd
Copy link

kbd commented Dec 26, 2018

I will add an option to disable scrolling.

Thanks! Came here to request this. While a useful feature, the scrolling keeps catching my eye and is distracting, and it's also hard to tell at a glance now what the author/track is because you might look at it at any point during the scroll.

Btw, something in 1.9 I hadn't noticed before is that the text turns white when you right click to bring up the context menu. Not sure if intended/desirable so I figured I'd mention it.

Thanks for SpotMenu!

@hkan
Copy link

hkan commented Dec 30, 2018

Also, an option to only scroll once would also be nice. On top of that, scrolling on mouse hover makes sense as well, as I could simply move my pointer over to menu bar to see the full title.

@ScottAlbertine
Copy link

I came here to request this feature, and I not only found it solved, but that the dev has updated the solved build twice with other features. This is amazing, and I love it.

Quick question: @kmikiy will that build you posted automatically update to the official release build (via the build in check for updates feature) when it comes out? Or will I need to download and install that official release once it's available?

@kmikiy
Copy link
Owner

kmikiy commented Jan 10, 2019

Quick question: @kmikiy will that build you posted automatically update to the official release build (via the build in check for updates feature) when it comes out? Or will I need to download and install that official release once it's available?

No need to download an official release, the build in check for updates should work

@PoppyS33d
Copy link

Wow. Came here to ask about disabling the scrolling (or to provide an option), and look - already done. Thank you SO much for this app. I love it!

@h0adp0re
Copy link

h0adp0re commented Mar 1, 2019

Any chance to see this in the settings any time soon?

@svenjacobs
Copy link

Also, an option to only scroll once would also be nice. On top of that, scrolling on mouse hover makes sense as well, as I could simply move my pointer over to menu bar to see the full title.

I second that! I think there should be four options regarding scrolling:

  1. No scrolling (like before 1.9 release)
  2. Always scroll
  3. Only scroll on mouse over
  4. Only scroll once per track

And let me say: Thank you very much for this great application! ❤

@connor-c
Copy link

My apologies. Here's an updated build for you.

  • no scrolling
  • vertical alignment fixed
  • spacing fixed

@kmikiy Could you possibly place this modified build's source code in a separate branch? I'm interested in adding the feature for turning on and off scrolling in the settings and then submitting it in a pull request. Thank you, this app is amazing and I use it on a daily basis!

@DFelten
Copy link

DFelten commented Jul 16, 2019

Thanks for the custom build! A setting for scrolling would be great since I sometimes like scrolling but when working this is a bit distracting.

@iansu iansu linked a pull request Aug 29, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants