Add xarray backend for Igor Pro files #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.pxt`, `.pxp`, and `.ibw` files can now be opened with xarray methods such as `xr.open_dataset` and `xr.open_dataarray`. See the updated user guide for more information.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 75.94% 77.36% +1.41%
==========================================
Files 64 65 +1
Lines 10543 10667 +124
==========================================
+ Hits 8007 8252 +245
+ Misses 2536 2415 -121 ☔ View full report in Codecov by Sentry. |
Calling `erlab.io.load_wave` and `erlab.io.load_experiment` is deprecated. When writing new code, use `xarray.load_dataarray` and `xarray.load_dataset` instead.
Whenever the `identify()` method failed to find any files, subclasses had to explicitly raise `FileNotFoundError`. This resulted in a lot of boilerplate code and ambiguous error messages. Now, all subclasses can just return `None` in `identify()` when no files are found. The appropriate error is automatically raised.
Memmapping seemed to interfere loading multiple files when called through ipywidgets.
kmnhan
force-pushed
the
dev-io
branch
5 times, most recently
from
4141c42
to
08930bb
Compare
The previous behavior allowed passing `f_001.pxt` to load `f_001_S001.pxt`, `f_001_S002.pxt`... but this was confusing since there is no file named `f_001.pxt`. This commit disallows such input.
Validation checks will not warn about missing detector angle, allowing XPS measurements.
…loaders Combining before renaming coords should be more straightforward
A new attribute named `formatters` and a new method `get_formatted_attr_or_coord` has been added to loaders. This allows custom per-attribute pretty-printing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a backend so that igor pro files (.pxp, .pxt, .ibw) can be opened with
xr.open_dataarrayandxr.open_dataset.Links:
https://docs.xarray.dev/en/stable/internals/how-to-add-new-backend.html
Change io functions to use xarray methods likexr.open_mfdatasetAfter testing with dask, joblib-based parallelization seems to work better (at least for igor files)
DataTreeand close Integrate DataTree #29