Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VirtualService match headers mapping #1348

Closed
wants to merge 1 commit into from
Closed

Fix VirtualService match headers mapping #1348

wants to merge 1 commit into from

Conversation

SharpEdgeMarshall
Copy link

Changes

  • 🐛 Fix bug

/kind bug

Fixes #1313

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 23, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SharpEdgeMarshall
Once this PR has been reviewed and has the lgtm label, please assign davidhadas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from izabelacg and skonto July 23, 2024 13:30
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 23, 2024

Welcome @SharpEdgeMarshall! It looks like this is your first PR to knative-extensions/net-istio 🎉

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 23, 2024

Hi @SharpEdgeMarshall. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SharpEdgeMarshall SharpEdgeMarshall changed the title Fix VirtualService match headers reconciliation Fix VirtualService match headers mapping Jul 23, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
@dprotaso
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 23, 2024

@SharpEdgeMarshall: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_net-istio_main 6079240 link true /test unit-tests
build-tests_net-istio_main 6079240 link true /test build-tests
latest-mesh_net-istio_main 6079240 link true /test latest-mesh
integration-tests_net-istio_main 6079240 link true /test integration-tests
latest_net-istio_main 6079240 link true /test latest

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dprotaso
Copy link
Contributor

Have the same fix out here with some unit tests

#1349

@dprotaso dprotaso closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izabelacg izabelacg Awaiting requested review from izabelacg

@skonto skonto Awaiting requested review from skonto

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wierd logic in genrating VirtualService Match headers.
2 participants
@SharpEdgeMarshall @dprotaso