Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

As knative admin, I want to list custom domains #30

Open
ZhuangYuZY opened this issue May 18, 2020 · 5 comments
Open

As knative admin, I want to list custom domains #30

ZhuangYuZY opened this issue May 18, 2020 · 5 comments
Assignees

Comments

@ZhuangYuZY
Copy link
Contributor

ZhuangYuZY commented May 18, 2020

Now we have kn admin domain set to set custom-domain. But we are missing a list command to show custom domains.

List Knative custom domain

Usage:
  kn admin domain list [flags]

Examples:

  # To list all custom domains
  kn admin domain list

Flags:
  -h, --help         help for list
      --no-headers   When using the default output format, don't print headers (default: print headers).

Global Flags:
      --config string   config file (default is $HOME/.config/kn/plugins/admin.yaml)

@ZhuangYuZY
Copy link
Contributor Author

@zhanggbj Based on our talk, there is pkg for format output. Could you please give a reference to implement domain list ? Thank you

@ZhuangYuZY
Copy link
Contributor Author

/assign
I also work on this new command.

@zhanggbj
Copy link

@ZhuangYuZY
As kn-admin is a plugin of kn client, I think it's good to align with kn client, althrough there're some common go pkg for printer.

  • Here is the pkg from kn client "knative.dev/client/pkg/printers"
  • We can refer to route list here

One concern from my side, if we're going to list all, I think there's no need to specify flags --custom-domain any more.

@ZhuangYuZY
Copy link
Contributor Author

ZhuangYuZY commented May 19, 2020

I remove the --custom-domain flag. Thank you.

@ZhuangYuZY
Copy link
Contributor Author

knative-extensions/kn-plugin-admin#3 created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants