From 129573e5317682ff20313922183688e4265f58b5 Mon Sep 17 00:00:00 2001 From: Navid Shaikh Date: Fri, 10 Apr 2020 17:27:49 +0530 Subject: [PATCH] e2e: Foreground delete for revisions and services in e2e to avoid any race conditions and flakes --- test/e2e/basic_workflow_test.go | 2 +- test/e2e/revision_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/basic_workflow_test.go b/test/e2e/basic_workflow_test.go index 129b06e518..2dc35cac30 100644 --- a/test/e2e/basic_workflow_test.go +++ b/test/e2e/basic_workflow_test.go @@ -122,7 +122,7 @@ func serviceUpdate(r *test.KnRunResultCollector, serviceName string, args ...str } func serviceDelete(r *test.KnRunResultCollector, serviceName string) { - out := r.KnTest().Kn().Run("service", "delete", serviceName) + out := r.KnTest().Kn().Run("service", "delete", "--no-wait=false", serviceName) r.AssertNoError(out) assert.Check(r.T(), util.ContainsAll(out.Stdout, "Service", serviceName, "successfully deleted in namespace", r.KnTest().Kn().Namespace())) } diff --git a/test/e2e/revision_test.go b/test/e2e/revision_test.go index c6b81e685a..e8375c2972 100644 --- a/test/e2e/revision_test.go +++ b/test/e2e/revision_test.go @@ -91,7 +91,7 @@ func revisionListWithService(r *test.KnRunResultCollector, serviceNames ...strin } func revisionDelete(r *test.KnRunResultCollector, revName string) { - out := r.KnTest().Kn().Run("revision", "delete", revName) + out := r.KnTest().Kn().Run("revision", "delete", "--no-wait=false", revName) assert.Check(r.T(), util.ContainsAll(out.Stdout, "Revision", revName, "deleted", "namespace", r.KnTest().Kn().Namespace())) r.AssertNoError(out) }