Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Eventing sources and messaging latest api version #1160

Closed
daisy-ycguo opened this issue Dec 2, 2020 · 5 comments
Closed

Upgrading to Eventing sources and messaging latest api version #1160

daisy-ycguo opened this issue Dec 2, 2020 · 5 comments
Labels
kind/feature New feature or request

Comments

@daisy-ycguo
Copy link
Member

Feature request

Eventing has changes their APIs to v1, including:

  • Channels from v1beta1 to v1
  • Subscription from v1beta1 to v1
  • ContainerSource to v1
  • pingsource resource to v1beta1
  • apiserversource to v1beta1
  • binding to v1beta1

We may want to support the latest version in Client.

@rhuss
Copy link
Contributor

rhuss commented Dec 15, 2020

@daisy-ycguo Actually, our strategy is a bit more defensive: We want to use the smallest support version of any API right now. The reasoning for this is laid out in #462

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2021
@rhuss
Copy link
Contributor

rhuss commented Mar 17, 2021

Maybe its a good time now to revisit the eventing API and what we are supporting and whether we need some alignment. Any volunteer to check those API versions ?

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2021
@rhuss
Copy link
Contributor

rhuss commented Jul 5, 2021

I think we already updated to the v1 versions where the beta versions were removed, so I'm good with closing this issue.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2021
@rhuss rhuss closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants