Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait-for-drain to AuthorizationPolicy for system paths used by Knative #3760

Closed
yanniszark opened this issue Jun 9, 2021 · 5 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/serving lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/nice-to-have triage/needs-eng-input Engineering input is requested
Milestone

Comments

@yanniszark
Copy link

Expected Behavior

In page https://knative.dev/v0.22-docs/serving/istio-authorization/#allowing-access-from-system-pods-by-paths, the given AuthorizationPolicy gives access to paths /metrics and /healthz. I expected the given AuthorizationPolicy to also include the /wait-for-drain path. Knative uses this path to wait until all requests in the queue are complete before terminating a Pod.

Actual Behavior

The included Authorization policy does not include the /wait-for-drain path.

@yanniszark yanniszark added the kind/bug Categorizes issue or PR as related to a bug. label Jun 9, 2021
@yanniszark yanniszark changed the title Enabling requests to Knative services when additional authorization policies are enabled(v0.22-docs/serving/istio-authorization.md) Add wait-for-drain to AuthorizationPolicy for system paths used by Knative Jun 9, 2021
@csantanapr
Copy link
Member

This issue is not specific to mkdocs new site
/remove-kind mkdocs

@csantanapr csantanapr added the triage/needs-eng-input Engineering input is requested label Jul 1, 2021
@csantanapr
Copy link
Member

csantanapr commented Jul 1, 2021

@dprotaso could you triage/handle this?

@abrennan89 abrennan89 added this to the Icebox milestone Jul 1, 2021
@snneji
Copy link
Contributor

snneji commented Jul 21, 2021

/priority medium

@abrennan89
Copy link
Contributor

cc @nak3 @houshengbo @markusthoemmes is this something you can maybe help to provide information for?

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/serving lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/nice-to-have triage/needs-eng-input Engineering input is requested
Projects
None yet
Development

No branches or pull requests

6 participants