Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DomainMapping to v1beta1 from v1alpha1 #5672

Closed
nak3 opened this issue Sep 1, 2023 · 1 comment · Fixed by #5673
Closed

Update DomainMapping to v1beta1 from v1alpha1 #5672

nak3 opened this issue Sep 1, 2023 · 1 comment · Fixed by #5673
Assignees
@xiangpingjiang

Comments

@nak3
Copy link
Contributor

nak3 commented Sep 1, 2023

What is changing? (Please include as many details as possible.)

knative/serving#14275 removed v1alpha1 so we need to update it.

How will this impact our users?

For example, https://knative.dev/development/serving/services/custom-domains/ still uses v1alpha1 for DM so I think it fails to create the DM.

In what release will this take happen (to the best of your knowledge)?

  • Next release (v1.12)

Context

Link to associated PRs or issues from other repos here.

  1. Just follow https://knative.dev/development/serving/services/custom-domains/
  2. It will get the following error.
: no matches for kind "DomainMapping" in version "serving.knative.dev/v1alpha1"
ensure CRDs are installed first
@nak3 nak3 mentioned this issue Sep 1, 2023
Merged
@xiangpingjiang
Copy link
Contributor

/assign

@xiangpingjiang xiangpingjiang mentioned this issue Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangpingjiang xiangpingjiang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update DomainMapping to v1beta1 from v1alpha1 xiangpingjiang/docs
2 participants
@nak3 @xiangpingjiang