Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding for blog post on improved event discovery #5616

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Adding for blog post on improved event discovery #5616

merged 7 commits into from
Aug 1, 2023

Conversation

matzew
Copy link
Member

@matzew matzew commented Jun 29, 2023

Proposed Changes

  • Adding blog to discuss new Event discovery features on Knative Eventing 1.11

/hold
DO NOT MERGE BEFORE THE 1.11 release

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 29, 2023
@knative-prow knative-prow bot requested review from psschwei and snneji June 29, 2023 09:53
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2023
@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df7c7dd
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64c907fa0fb46b00081eec24
😎 Deploy Preview https://deploy-preview-5616--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matzew
Copy link
Member Author

matzew commented Jun 29, 2023

Event Types, Event Types! EVERYWHERE
(for improved discoverability and developer experience)

matzew
matzew commented Jul 26, 2023
View reviewed changes
blog/docs/articles/new_event_discovery_features.md Outdated
@@ -70,7 +70,8 @@ default 93774a924a741245a94313745d78e69f dev.knative.sources.ping /apis/
```
#### Auto Event Type creation

tbd
Furthermore to improve the experience with `EventTypes` consumption and creation, there's a new experimental feature to automatically create `EventTypes` objects based on processed events on the broker ingress. Instead of manually creating them as yaml manifests along the application code that talks to the Broker API. This behaviour can be enabled by feature flag `eventtype-auto-creation` in `config-features` ConfigMap. For futher details and examples pleaase refer to [the documentation](https://knative.dev/docs/eventing/experimental-features/eventtype-auto-create/).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @Cali0707 added this for 1.11 release also for the IMC, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this should work for IMC now!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cali0707 PTAL on the current update. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dsimansk !

@dsimansk dsimansk changed the title WIP: Adding DRAFT for blog post on improved event discovery Adding DRAFT for blog post on improved event discovery Aug 1, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2023

@matzew it's ready for a final look.

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
@dsimansk dsimansk changed the title Adding DRAFT for blog post on improved event discovery Adding for blog post on improved event discovery Aug 1, 2023
matzew
matzew commented Aug 1, 2023
View reviewed changes
Copy link
Member Author

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

@matzew: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member Author

matzew commented Aug 1, 2023

Thanks for contributing to this PR

/assign @psschwei

psschwei
psschwei reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a link in the blog nav.yml, but otherwise looks good to me.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2023
@matzew matzew force-pushed the new_event_type_enhancements_eventing_1.1_release branch from 84277e5 to df7c7dd Compare August 1, 2023 13:26
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2023
@matzew
Copy link
Member Author

matzew commented Aug 1, 2023

@psschwei rebased, and added a new link to the one.

psschwei
psschwei reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@knative-prow knative-prow bot merged commit 49750e9 into knative:main Aug 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk left review comments

@psschwei psschwei psschwei left review comments

@Cali0707 Cali0707 Cali0707 left review comments

@snneji snneji Awaiting requested review from snneji

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matzew @dsimansk @psschwei @Cali0707 @knative-prow-robot