Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding blog on Knative Vision #5638

Merged
merged 18 commits into from
Aug 7, 2023
Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Jul 26, 2023

Proposed Changes

  • adding a Knative Eventing Vision blog, showing what's coming in the next month(s)

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@knative-prow knative-prow bot requested review from nainaz and psschwei July 26, 2023 09:58
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6c640d3
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64cbc3a7e85c4800089c149e
😎 Deploy Preview https://deploy-preview-5638--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2023

Knative defines an EventType API which allows for discovery of the types of events that are available in the Knative Eventing system. This helps developers understand what kinds of events can be listened to and processed, which can be particularly helpful in systems with a large number of events being produced.

However currently the EventType is unfortunately underused and is limited to Source-Duck compliant sources, in combination with the Knative Broker API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any links to "Source-Duck compliant sources" ? I guess only 5-6 people will get what this means in the entire world :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is a fact, since that auto-create only works under some rules.

Any suggestion to say this differently?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like

"However currently the EventType is unfortunately underused and is limited to sources which are compliant with / implement the Knative Source Ducktype, in combination with the Knative Broker API"


### Authorization and admission policies

Event-driven architecture is meant to lower organizations' silos and barriers, make systems more resilient and ultimately increase business agility, however, this is not possible without event admission policies and safeguards for security and data quality.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other sections have a section about what the current state is. Wanna write something similar?

Even if that we don't have anything, and brokers+channels+etc will simply accept any events.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi can you take a look here?

I think it is a good suggestion by Ali

@aliok
Copy link
Member

aliok commented Jul 26, 2023

I like it overall. Some diagrams would have been great, although that's a lot of work.

Thanks for putting it together

blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
blog/docs/articles/knative-eventing-vision.md Outdated Show resolved Hide resolved
@matzew matzew changed the title WIP: Adding blog on Knative Vision Adding blog on Knative Vision Jul 26, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for providing this.
Overall seems LGTM so far


For more information, please refer to the [feature track document](https://docs.google.com/document/d/1H-x_oji8LqkCyd7tlsSyclmUe7FAmEJPgRxOU_0pkn8/edit).

### Sender identity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only wondering if "Authentication" would be a better heading, as it's more often referenced 🤔
But of course, only personal opinionated...

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
Comment on lines 46 to 49
For more detailed information, please refer to
the [transport-encryption feature](https://github.com/knative/docs/pull/5642)

/* TODO use real feature docs link once PR above is in */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a TODO after #5642

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@creydr
Copy link
Member

creydr commented Aug 3, 2023

/hold
wait for #5638 (comment)

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 3, 2023
@matzew
Copy link
Member Author

matzew commented Aug 3, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
the [transport-encryption feature](https://github.com/knative/docs/pull/5642)

/* TODO use real feature docs link once PR above is in */
the [transport-encryption feature](https://knative.dev/docs/eventing/experimental-features/transport-encryption/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a relative file link here, not absolute URLs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always used actual links for pointers to documentation 🤷‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is not working in preview, but I think its, because you didn't rebase after #5642 merged.
/lgtm

/hold
to give others a chance to review too. Otherwise unhold...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why tho, perhaps let's just go with direct links?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog and the docs are technically two different builds, so relative links won't work across them... in the nav, you need to use something like /docs/eventing/experimental... , but I don't recall offhand if that also works from the docs themselves

(there's some more info on the setup at https://github.com/knative/docs/tree/main/blog#docsblogconfignavyml)

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 3, 2023
matzew and others added 17 commits August 3, 2023 17:07
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Copy link
Member Author

matzew commented Aug 3, 2023

I've rebased and again updated it.

@psschwei that /doc... seems to work now

Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from a docs perspective
/approve

@knative-prow
Copy link

knative-prow bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@pierDipi
Copy link
Member

pierDipi commented Aug 4, 2023

/lgtm

@matzew
Copy link
Member Author

matzew commented Aug 7, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2023
@knative-prow knative-prow bot merged commit 22b3494 into knative:main Aug 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants