Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* First draft of the default broker class code Signed-off-by: Leo Li <[email protected]> * Change the default broker class config Signed-off-by: Leo Li <[email protected]> * Run codegen Signed-off-by: Leo Li <[email protected]> * Refactor the code Signed-off-by: Leo Li <[email protected]> * Codegen Signed-off-by: Leo Li <[email protected]> * Fix the build error and run code gen Signed-off-by: Leo Li <[email protected]> * Fix the build error in the tests Signed-off-by: Leo Li <[email protected]> * Fix the build error in the tests Signed-off-by: Leo Li <[email protected]> * Modify the current existing test, and add more test cases Signed-off-by: Leo Li <[email protected]> * Modify the current existing test, and add more test cases Signed-off-by: Leo Li <[email protected]> * Pass in the actual broker name instead of leaving it empty Signed-off-by: Leo Li <[email protected]> * Modify the condition to check whether Different Namespace is allowed according to the default configs Signed-off-by: Leo Li <[email protected]> * Revert the brokerSpec.Name change. Signed-off-by: Leo Li <[email protected]> * Fix the failing unit tests by adding the default config for the defaults Signed-off-by: Leo Li <[email protected]> * Fix the failing unit tests Signed-off-by: Leo Li <[email protected]> * Fix the review comments Signed-off-by: Leo Li <[email protected]> * Update pkg/apis/config/defaults.go Co-authored-by: Christoph Stäbler <[email protected]> * Change the tests to be table form Signed-off-by: Leo Li <[email protected]> * Check if the brokerClassName is the default broker class for the whole cluster Signed-off-by: Leo Li <[email protected]> * Fixed the build error Signed-off-by: Leo Li <[email protected]> * fix: instead of always passing the empty className, pass in the variable instead Signed-off-by: Leo Li <[email protected]> * fix: brokerClass is a string pointer. If the value is null but pointer has value, it will pass. So this commit fix that problem. Signed-off-by: Leo Li <[email protected]> * feat: adding some temporary test cases for testing purposes Signed-off-by: Leo Li <[email protected]> * feat: adding some temporary test cases for testing purposes Signed-off-by: Leo Li <[email protected]> * fix: fix the failing tests Signed-off-by: Leo Li <[email protected]> * fix: fix FIXME, the issue that can potentially cause SegFault Signed-off-by: Leo Li <[email protected]> * fix: fix the failing rabbitmq issue Signed-off-by: Leo Li <[email protected]> * fix: remove the trailing whitespace Signed-off-by: Leo Li <[email protected]> * fix: update the comments Signed-off-by: Leo Li <[email protected]> * feat: add the high level summary for the code Signed-off-by: Leo Li <[email protected]> * fix: fix the review comments Signed-off-by: Leo Li <[email protected]> * fix: fix the review comments Signed-off-by: Leo Li <[email protected]> * fix: fix Calum's review comments Signed-off-by: Leo Li <[email protected]> * fix: fix failed unit test caused by the latest review comment fix Signed-off-by: Leo Li <[email protected]> * fix: fix failed unit test caused by the latest review comment fix Signed-off-by: Leo Li <[email protected]> * feat: add the test for the deprecating default broker config feature Signed-off-by: Leo Li <[email protected]> --------- Signed-off-by: Leo Li <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]>
- Loading branch information