From 5f921643f19b764f794c2aeb3983974c7c1e0096 Mon Sep 17 00:00:00 2001 From: Knative Prow Robot Date: Thu, 27 Jun 2024 17:37:46 +0100 Subject: [PATCH] [release-1.14] Avoid fatal errors for unknown features flags that can be added in a future release (#8052) Avoid fatal errors for unknown features flags that can be added in a future release Signed-off-by: Pierangelo Di Pilato Co-authored-by: Pierangelo Di Pilato --- pkg/apis/feature/features.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/apis/feature/features.go b/pkg/apis/feature/features.go index 9fc57664e53..95ca6151189 100644 --- a/pkg/apis/feature/features.go +++ b/pkg/apis/feature/features.go @@ -18,6 +18,7 @@ package feature import ( "fmt" + "log" "strings" corev1 "k8s.io/api/core/v1" @@ -148,7 +149,8 @@ func NewFlagsConfigFromMap(data map[string]string) (Flags, error) { } else if strings.Contains(k, NodeSelectorLabel) { flags[sanitizedKey] = Flag(v) } else { - return flags, fmt.Errorf("cannot parse the feature flag '%s' = '%s'", k, v) + flags[k] = Flag(v) + log.Printf("Warning: unknown feature flag value %q=%q\n", k, v) } }