-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Broker pods die if tracing configmap is malformed on start #1417
Comments
/priority important-soon |
/milestone v0.8.0 |
So the logic to manage tracing with Zipkin shall be reviewed and updated. |
Several pods with dependency on Zipkin are affected by this issue, not only
The root cause is So we'd better create an issue in serving and fix it there. |
/milestone v0.9.0 |
/project Observability To do |
/milestone v0.10.0 |
This issue is stale because it has been open for 90 days with no |
Describe the bug
If the tracing configmap is updated to include the key
enabled: "true"
but nozipkin-endpoint
key, the Broker pods log an error but keep operating. They will fail to start upon the next restart.Expected behavior
The pod should use the default value, or disable tracing and continue. Tracing is an observability feature and its misconfiguration shouldn't cause the Broker to stop working. The fact that the bug is triggered by a restart means the failure will be difficult to associate with the root cause.
To Reproduce
config-tracing
configmap in the Broker's namespace with the keyenabled: "true"
.Knative release version
Eventing HEAD, Serving 0.6
Additional context
The text was updated successfully, but these errors were encountered: