-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Broker class spec based default #6621
Closed
liuchangyan
wants to merge
9
commits into
knative:main
from
liuchangyan:KNATIVE_Add-BrokerClass-based-default
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
520c7cb
Add Broker class spec based default
liuchangyan 3ef5c30
code cleanup and bug fix
liuchangyan ca0f0e7
unit test bug fix
liuchangyan 2ad62d2
Update codegen
liuchangyan e942ada
broker setDefault unit test add
liuchangyan 1fa7225
remove Deprecated StringPtr/Int32Ptr to String/Int32
liuchangyan d247b0f
fix codegen error
liuchangyan 375ef8e
broker setDefault unit test add
liuchangyan 3ba0387
unit tests cleanup
liuchangyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call all
brokerSpec<X>
variables with the associated class for clarity likebrokerSpecMTChannelBasedBroker
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it