Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runtime/debug in our changeset package #2427

Closed
dprotaso opened this issue Feb 15, 2022 · 3 comments · Fixed by #2548
Closed

Use runtime/debug in our changeset package #2427

dprotaso opened this issue Feb 15, 2022 · 3 comments · Fixed by #2548
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dprotaso
Copy link
Member

Did some testing - runtime/debug probably won't be super useful until 1.18, particularly for local changes.

The main module info for something built not at a semver tag looks like:

Main:{Path:knative.dev/pkg Version:(devel) Sum: Replace:<nil>}

What we really want are the vcs tags included in 1.18 which look like:

Settings:[
 {Key:-compiler Value:gc}
 {Key:CGO_ENABLED Value:1}
 {Key:CGO_CFLAGS Value:}
 {Key:CGO_CPPFLAGS Value:} 
 {Key:CGO_CXXFLAGS Value:}
 {Key:CGO_LDFLAGS Value:} 
 {Key:GOARCH Value:amd64} 
 {Key:GOOS Value:linux} 
 {Key:GOAMD64 Value:v1} 
 {Key:vcs Value:git} 
 {Key:vcs.revision Value:62b1122c86b2f032117da832332037ff511c2b74} 
 {Key:vcs.time Value:2022-02-11T23:48:33Z} 
 {Key:vcs.modified Value:true}
]

Originally posted by @wlynch in #2425 (comment)

@dprotaso
Copy link
Member Author

We should switch over when we start using go1.18 for building

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2022
@dprotaso
Copy link
Member Author

/lifecycle frozen

@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant