Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target-utilization-percentage does not seem to be working as expected #12888

Closed
moadi opened this issue Apr 27, 2022 · 1 comment
Closed

target-utilization-percentage does not seem to be working as expected #12888

moadi opened this issue Apr 27, 2022 · 1 comment
Labels
kind/question Further information is requested

Comments

@moadi
Copy link

moadi commented Apr 27, 2022

Ask your question here:

Hey folks,

We're currently using KN v0.24 in production for our services. Unrelated to this issue, but we had tried to upgrade but weren't able to do so cleanly due to what seems like a bug in the go runtime when a request body is read by the queue-proxy, which is why we're "stuck" on this version for the time being. We will attempt an upgrade soon.

Some of our java services are slow to startup, so we were hoping to use the target utilization percentage annotation on the revision to be able to scale up earlier in anticipation of increased load before we hit peak traffic. Our containerConcurrency is set to 6, min scale is set to 10, which gives us a capacity of 60 inflight requests. As a test, we set the annotation autoscaling.knative.dev/target-utilization-percentage to 33 hoping that we'd see the scale up happen as our stable concurrency hit ~20. Our stable window is set to 120s.

Instead, when the service is running we don't see new replicas being created until much later. New replicas seem to be created only when the autoscaler panics, at which point the stable request concurrency is almost 40 - which seems to correspond to a target utilization of like 66%.

Are we misunderstanding how this param is supposed to work? Is there a reason why new replicas aren't being created even when the stable request concurrency exceeds our target threshold of 33%?

@moadi moadi added the kind/question Further information is requested label Apr 27, 2022
@moadi
Copy link
Author

moadi commented Apr 27, 2022

I presume this annotation doesn't exist in v0.24 and only the global one can be specified?

Edit: just checked the code and that does seem to be the case. Sounds like we need to upgrade after all! 😄

@moadi moadi closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant