Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the appropriate h2c appProtocol label so our K8s Services work with Gateway API #14569

Closed
dprotaso opened this issue Oct 26, 2023 · 3 comments
Assignees
Milestone

Comments

@dprotaso
Copy link
Member

Feature Request

Currently we are not setting known appProtocol values to indicate our backends expect a certain protocol. This is the mechanic used by Gateway API implementations

ref: istio/istio#47610
ref: projectcontour/contour#5897

I think we should start with h2c first since we have a mechanic defined in our runtime contract to specify that protocol.

For websocket - this in theory should just be on by default (contour toggled it on for Gateway API). There might be other implementations that have this off but let's revisit that when we find one that doesn't

@dprotaso dprotaso added this to the v1.13.0 milestone Oct 26, 2023
@gabo1208
Copy link
Member

gabo1208 commented Nov 6, 2023

/assign

@dprotaso
Copy link
Member Author

Interestingly enough I wonder if adding the app protocol broke net-gateway-api

see the dependency bump here: #14789

@dprotaso
Copy link
Member Author

dprotaso commented Mar 5, 2024

Verified with the networking conformance that this should work now with our net-gateway-api integration

knative-extensions/net-gateway-api#635

@dprotaso dprotaso closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants