Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename UserContainer to ServingContainer #15007

Open
4 tasks
ReToCode opened this issue Mar 13, 2024 · 15 comments · May be fixed by #15330
Open
4 tasks

Rename UserContainer to ServingContainer #15007

ReToCode opened this issue Mar 13, 2024 · 15 comments · May be fixed by #15330
Assignees
@EraKin575
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/refactoring lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Icebox

Comments

@ReToCode
Copy link
Member

Description

We currently name the "main" container of a KnativeService UserContainer. As all containers, including sidecars, are provided by the user this name is not ideal. We should check if it is feasible to rename it to ServingContainer without breaking our API.

Todo

  • Check if UserContainer can be renamed without breaking the API
  • If possible, rename all occurrences in pkg
  • If possible, rename all occurrences in serving
  • If possible, rename all occurrences in docs
@ReToCode ReToCode added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/refactoring labels Mar 13, 2024
@ReToCode ReToCode mentioned this issue Mar 13, 2024
Merged
@skonto
Copy link
Contributor

skonto commented Mar 13, 2024

ServingContainer sounds like that the container belongs to Serving somehow though.
I would prefer something like "AppContainer", "MainContainer", "PrimaryContainer" wdyth?

@ReToCode
Copy link
Member Author

Hm it is the container that serves the traffic, so I'm also throwing TrafficContainer in here :) Opinions?

@dprotaso @rhuss

@rhuss
Copy link
Contributor

rhuss commented Mar 13, 2024

+1 one for what @skonto says; the name should reflect its key characteristics. TrafficContainer depicts it, but without context, it sounds weird and confusing, IMO. I like MainContainer because that's what it is, the MainContainer, all others are sidecar containers. Another option, which kind of is in-between, could be TargetContainer, but I think MainContainer is clear and simple and is an established 'concept'.

@prashantrewar
Copy link

Hey @ReToCode, @rhuss, and @skonto, I want to work on this issue.

@dprotaso dprotaso added this to the Icebox milestone Apr 1, 2024
@NightFury742
Copy link

/assign

@asr2003
Copy link

asr2003 commented May 28, 2024

/assign

@dprotaso
Copy link
Member

/unassign @asr2003

the issue is already assigned to @NightFury742

This was referenced May 28, 2024
Closed
Closed
@EraKin575 EraKin575 linked a pull request Jun 17, 2024 that will close this issue
Open
@EraKin575
Copy link

if @NightFury742 is not working on this issue, can I work on this?

@dprotaso
Copy link
Member

@NightFury742 can you comment if you're still working on this issue?

@NightFury742
Copy link

@dprotaso I am not working on it. @EraKin575 could take this one

@dprotaso
Copy link
Member

/unassign @NightFury742
/assign @EraKin575

@knative-prow knative-prow bot assigned EraKin575 and unassigned NightFury742 Jun 27, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2024
@ReToCode
Copy link
Member Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2024
@ReToCode ReToCode added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 26, 2024
@palSagnik
Copy link

@EraKin575 if you are not working on this issue can I tackle it?

@EraKin575
Copy link

@EraKin575 if you are not working on this issue can I tackle it?

Yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EraKin575 EraKin575

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/refactoring lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
Icebox
Development

Successfully merging a pull request may close this issue.

rename user container to main container EraKin575/serving
9 participants
@dprotaso @rhuss @skonto @ReToCode @EraKin575 @prashantrewar @palSagnik @NightFury742 @asr2003