Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder k8s service reconciliation doesn't take defaulter into account when diffing #1637

Closed
mdemirhan opened this issue Jul 20, 2018 · 1 comment
Closed

Placeholder k8s service reconciliation doesn't take defaulter into account when diffing #1637

mdemirhan opened this issue Jul 20, 2018 · 1 comment
Assignees
@mdemirhan
Labels
area/networking kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mdemirhan
Copy link
Contributor

Expected Behavior

Placeholder k8s service for a revision gets reconciled every 30 seconds due to fighting with the defaulter. We should ignore the fields that are set by the defaulter and not reconcile on those fields.

Actual Behavior

Logs show the following diff causing us to reconcile today:

Reconciling service diff (-desired, +observed): 
{v1.ServiceSpec}.Ports[0].Protocol: 	-: v1.Protocol("") 	+: v1.Protocol("TCP") {v1.ServiceSpec}.Ports[0].NodePort: 	-: 0 	+: 30914 
{v1.ServiceSpec}.SessionAffinity: 	-: v1.ServiceAffinity("") 	+: v1.ServiceAffinity("None") {v1.ServiceSpec}.ExternalTrafficPolicy: 	-: v1.ServiceExternalTrafficPolicyType("") 	+: v1.ServiceExternalTrafficPolicyType("Cluster")
@google-prow-robot google-prow-robot added area/networking kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 20, 2018
@mdemirhan mdemirhan changed the title Placeholder k8s service reconcilliation issue Placeholder k8s service reconciliation issue Jul 20, 2018
@mdemirhan mdemirhan changed the title Placeholder k8s service reconciliation issue Placeholder k8s service reconciliation doesn't take into account the defaulter when diffing Jul 20, 2018
@mdemirhan mdemirhan changed the title Placeholder k8s service reconciliation doesn't take into account the defaulter when diffing Placeholder k8s service reconciliation doesn't take defaulter into account when diffing Jul 20, 2018
@tcnghia
Copy link
Contributor

tcnghia commented Jul 20, 2018

Placehold service will be changed to ExternalName in #1609 which probably will fix these.

@tcnghia tcnghia closed this as completed Aug 13, 2018
@jonjohnsonjr jonjohnsonjr mentioned this issue Aug 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdemirhan mdemirhan

Labels
area/networking kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcnghia @mdemirhan @google-prow-robot