fix cluster-local routes being stalled when external-domain-tls is enabled

[dprotaso]

Fixes: #15232

Proposed Changes

• Fix cluster.local Routes not reconciling when external-tls is enabled

Release Note

Fix cluster.local Routes not reconciling when external-tls is enabled

[dprotaso]

/assign @ReToCode

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.75%. Comparing base (a0a1ac7) to head (06d7e60).
Report is 4 commits behind head on main.

Files	Patch %	Lines
pkg/reconciler/route/route.go	75.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15234      +/-   ##
==========================================
- Coverage   84.76%   84.75%   -0.01%     
==========================================
  Files         218      218              
  Lines       13473    13479       +6     
==========================================
+ Hits        11420    11424       +4     
- Misses       1687     1688       +1     
- Partials      366      367       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

/cherry-pick release-1.14

[knative-prow-robot]

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dprotaso]

/retest

[ReToCode]

Aw, that is a tricky one. The code was confusing before, but with this it is even more implicit. Maybe it would be a good idea to introduce another condition to separate cluster-local from external-domain certificates? It's a bit hard to follow that the condition is influenced by two feature flags and if there is actually a route (e.g. external-domain-tls enabled but no external routes and cluster-local-domain-tls disabled).

We could even have better messages like

• external-domain-tls: feature is disabled
• external-domain-tls: no certificate required, no external domains found

@dprotaso WDYT? And if ok, this PR or we can do it as a followup for 1.15?

[dprotaso]

@dprotaso WDYT? And if ok, this PR or we can do it as a followup for 1.15?

Lets talk about this and do follow up for 1.15 - can you make an issue? This PR is to unblock the bug and cherry-pick back to 1.14 release branch.

[ReToCode]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ReToCode,dprotaso]
• pkg/apis/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@dprotaso: new pull request created: #15243

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.