Clean up job for old resources #15312
Conversation
knative-prow
bot
added
do-not-merge/work-in-progress
|
/assign @dprotaso |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15312 +/- ##
==========================================
- Coverage 84.78% 84.51% -0.27%
==========================================
Files 218 219 +1
Lines 13482 13544 +62
==========================================
+ Hits 11431 11447 +16
- Misses 1685 1730 +45
- Partials 366 367 +1 ☔ View full report in Codecov by Sentry. |
|
|
skonto
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
/retest ControllerHA flake |
config/post-install/cleanup.yaml
Outdated
| app.kubernetes.io/version: devel | ||
| app.kubernetes.io/name: knative-serving | ||
| rules: | ||
| - apiGroups: ["rbac.authorization.k8s.io"] |
There was a problem hiding this comment.
Should probably limit this to just the single role we need to delete
resourceNames: ["..."]There was a problem hiding this comment.
Oddly this role becomes a lingering resources after this job runs.
I wonder if we should just move this to serving-core role?
There was a problem hiding this comment.
The problem is that if we move it there, people who want to run this they will need to update the serving-core manually as well if they are targeting an old version (instead of just running a job). Anyway I think release notes could help.
pkg/cleanup/cmd/cleanup/cleanup.go
Outdated
| logger.Fatal("failed to list deployments: ", err) | ||
| } | ||
| for _, dep := range deps.Items { | ||
| if hasPrefix(dep.Name) { |
There was a problem hiding this comment.
Don't we know the exact names of the deployments we want to delete?
There was a problem hiding this comment.
Probably a relic need to update.
|
@dprotaso ready. |
|
@dprotaso gentle ping |
|
@dprotaso gentle ping. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #15247
Proposed Changes
Release Note